components/page_load_metrics/renderer/metrics_render_frame_observer.cc - Issue 1890853002: Add null check for page_load_metrics timing sender

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1890853002: Add null check for page_load_metrics timing sender (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

index 260d3b6285d48c68a63ce22b127e9b70890555ad..311d857a2066b369c15323c41cb789cb835d96de 100644

--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

@@ -41,8 +41,8 @@ void MetricsRenderFrameObserver::DidChangePerformanceTiming() {

void MetricsRenderFrameObserver::DidObserveLoadingBehavior(

blink::WebLoadingBehaviorFlag behavior) {

- DCHECK(page_timing_metrics_sender_);

- page_timing_metrics_sender_->DidObserveLoadingBehavior(behavior);

+ if (page_timing_metrics_sender_)

+ page_timing_metrics_sender_->DidObserveLoadingBehavior(behavior);

}

void MetricsRenderFrameObserver::DidCommitProvisionalLoad(

« no previous file with comments | « no previous file | no next file » | no next file with comments »