Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: third_party/WebKit/public/web/WebConsoleMessage.h

Issue 1890513004: Remove dependency on the DevTools agent for console logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added new enum to WebConsoleMessage to mirror MessageSource and more. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebConsoleMessage.h
diff --git a/third_party/WebKit/public/web/WebConsoleMessage.h b/third_party/WebKit/public/web/WebConsoleMessage.h
index d0a109c348648438725fa143008e69ce0fb816cf..2674a69202f7009d29888f99a6299412c494a09a 100644
--- a/third_party/WebKit/public/web/WebConsoleMessage.h
+++ b/third_party/WebKit/public/web/WebConsoleMessage.h
@@ -46,14 +46,30 @@ struct WebConsoleMessage {
LevelLast = LevelInfo
};
+ enum Source {
dcheng 2016/04/14 17:29:11 enum class Source.
carlosk 2016/04/15 09:42:43 Done.
+ SourceXML,
+ SourceJS,
+ SourceNetwork,
+ SourceConsoleAPI,
+ SourceStorage,
+ SourceAppCache,
+ SourceRendering,
+ SourceSecurity,
+ SourceOther,
+ SourceDeprecation,
+ SourceLast = SourceDeprecation
+ };
+
Level level;
WebString text;
WebString url;
+ Source source;
unsigned lineNumber;
unsigned columnNumber;
WebConsoleMessage()
: level(LevelLog)
+ , source(SourceOther)
, lineNumber(0)
, columnNumber(0)
{
@@ -61,6 +77,7 @@ struct WebConsoleMessage {
WebConsoleMessage(Level level, const WebString& text)
: level(level)
, text(text)
+ , source(SourceOther)
, lineNumber(0)
, columnNumber(0)
{

Powered by Google App Engine
This is Rietveld 408576698