Remove dependency on the DevTools agent for console logs.

third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 765da87a8896da493e0798b6a11908ce10a3dafc..73e0eeb259f5870916d35f874825ff0bec949e6d 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -769,7 +769,44 @@ void WebLocalFrameImpl::addMessageToConsole(const WebConsoleMessage& message)
         return;
     }
 
-    frame()->document()->addConsoleMessage(ConsoleMessage::create(OtherMessageSource, webCoreMessageLevel, message.text, message.url, message.lineNumber, message.columnNumber));
+    MessageSource webCoreMessageSource;
+    switch (message.source) {
+    case WebConsoleMessage::SourceXML:

[dcheng, 2016/04/14 17:29:11]

FWIW, the usual idiom is to make the core and web enums match. There's a bunch
of static_asserts that guarantee this to be so, and then we just static cast
across the boundary. But I guess this is matching the existing code...

[carlosk, 2016/04/15 09:42:43]

Static casting was I wanted to do initially but again I'm just matching what's
already in place. If it is acceptable I'll be glad to change both switch-case
blocks here.

And only now I found (and added) the value checking static asserts in
AssertMatchingEnums.cpp.

+        webCoreMessageSource = XMLMessageSource;
+        break;
+    case WebConsoleMessage::SourceJS:
+        webCoreMessageSource = JSMessageSource;
+        break;
+    case WebConsoleMessage::SourceNetwork:
+        webCoreMessageSource = NetworkMessageSource;
+        break;
+    case WebConsoleMessage::SourceConsoleAPI:
+        webCoreMessageSource = ConsoleAPIMessageSource;
+        break;
+    case WebConsoleMessage::SourceStorage:
+        webCoreMessageSource = StorageMessageSource;
+        break;
+    case WebConsoleMessage::SourceAppCache:
+        webCoreMessageSource = AppCacheMessageSource;
+        break;
+    case WebConsoleMessage::SourceRendering:
+        webCoreMessageSource = RenderingMessageSource;
+        break;
+    case WebConsoleMessage::SourceSecurity:
+        webCoreMessageSource = SecurityMessageSource;
+        break;
+    case WebConsoleMessage::SourceOther:
+        webCoreMessageSource = OtherMessageSource;
+        break;
+    case WebConsoleMessage::SourceDeprecation:
+        webCoreMessageSource = DeprecationMessageSource;
+        break;
+    default:

[dcheng, 2016/04/14 17:29:11]

That being said, if you keep the switch (though it should be moved to a central
place, probably the file that defines WebConsoleMessage::Source), remove the
default case since this will keep the compiler from emitting errors for
unhandled enum values. Same with the previous switch.

[carlosk, 2016/04/15 09:42:43]

My rule of thumb is to create a central, shared method when there's more than
one use of it which is not the case here. If pfeldman@ confirms he still thinks
I should re-add the devtools_agent method than that would be the case and I will
do so.

WDYT?

Note: that method can't be created in WebConsoleMessage because code in public/
can't import from core/ [1].
Done. I coupled that with setting a default for the output value to avoid
undefined behavior. Notice this changes the existing behavior for unsupported
values from a crash/ignore to having a log.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

+        NOTREACHED();
+        return;
+    }
+
+    frame()->document()->addConsoleMessage(ConsoleMessage::create(webCoreMessageSource, webCoreMessageLevel, message.text, message.url, message.lineNumber, message.columnNumber));
 }
 
 void WebLocalFrameImpl::collectGarbage()