Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
index 0889a3f70005d2e980887351f7796f26528b1db2..c1d24674d7935fe14626001c69b7b968d697eab2 100644
--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
@@ -177,12 +177,6 @@ WebPerformance WebRemoteFrameImpl::performance() const
return WebPerformance();
}
-bool WebRemoteFrameImpl::dispatchBeforeUnloadEvent()
-{
- NOTREACHED();
- return false;
-}
-
void WebRemoteFrameImpl::dispatchUnloadEvent()
{
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698