Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "web/WebRemoteFrameImpl.h" 5 #include "web/WebRemoteFrameImpl.h"
6 6
7 #include "core/frame/FrameView.h" 7 #include "core/frame/FrameView.h"
8 #include "core/frame/Settings.h" 8 #include "core/frame/Settings.h"
9 #include "core/html/HTMLFrameOwnerElement.h" 9 #include "core/html/HTMLFrameOwnerElement.h"
10 #include "core/layout/LayoutObject.h" 10 #include "core/layout/LayoutObject.h"
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 // code tries to access the document of a remote frame at the moment. 170 // code tries to access the document of a remote frame at the moment.
171 return WebDocument(); 171 return WebDocument();
172 } 172 }
173 173
174 WebPerformance WebRemoteFrameImpl::performance() const 174 WebPerformance WebRemoteFrameImpl::performance() const
175 { 175 {
176 NOTREACHED(); 176 NOTREACHED();
177 return WebPerformance(); 177 return WebPerformance();
178 } 178 }
179 179
180 bool WebRemoteFrameImpl::dispatchBeforeUnloadEvent()
181 {
182 NOTREACHED();
183 return false;
184 }
185
186 void WebRemoteFrameImpl::dispatchUnloadEvent() 180 void WebRemoteFrameImpl::dispatchUnloadEvent()
187 { 181 {
188 NOTREACHED(); 182 NOTREACHED();
189 } 183 }
190 184
191 void WebRemoteFrameImpl::executeScript(const WebScriptSource&) 185 void WebRemoteFrameImpl::executeScript(const WebScriptSource&)
192 { 186 {
193 NOTREACHED(); 187 NOTREACHED();
194 } 188 }
195 189
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 686
693 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope, WebRemoteFrameCli ent* client) 687 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope, WebRemoteFrameCli ent* client)
694 : WebRemoteFrame(scope) 688 : WebRemoteFrame(scope)
695 , m_frameClient(RemoteFrameClientImpl::create(this)) 689 , m_frameClient(RemoteFrameClientImpl::create(this))
696 , m_client(client) 690 , m_client(client)
697 , m_selfKeepAlive(this) 691 , m_selfKeepAlive(this)
698 { 692 {
699 } 693 }
700 694
701 } // namespace blink 695 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698