content/browser/frame_host/render_frame_host_impl.h - Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1890493002: PlzNavigate: properly execute BeforeUnload on renderer initiated navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed dcheng's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/test_runner_for_specific_view.cc ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index cce826fe6e816eaa66d277ac1703be1f44e5aeb7..a94c743d19ffba9cc7e6a818ae7fbd3519ff71f5 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -397,9 +397,12 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,

// Runs the beforeunload handler for this frame. |for_navigation| indicates

// whether this call is for the current frame during a cross-process

- // navigation. False means we're closing the entire tab.

+ // navigation. False means we're closing the entire tab. |is_reload|

+ // indicates whether the navigation is a reload of the page or a different

nasko 2016/05/09 21:56:04 nit: s/or a different kind of navigation/or not/

clamy 2016/05/10 01:58:09 Done.

+ // kind of navigation. If |for_navigation| is false, |is_reload| should be

+ // false as well.

// PlzNavigate: this call happens on all browser-initiated navigations.

- void DispatchBeforeUnload(bool for_navigation);

+ void DispatchBeforeUnload(bool for_navigation, bool is_reload);

// Returns true if a call to DispatchBeforeUnload will actually send the

// BeforeUnload IPC. This is the case if the current renderer is live and this