PlzNavigate: properly execute BeforeUnload on renderer initiated navigations

content/browser/frame_host/render_frame_host_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 379 matching lines @@
   void SetNavigationsSuspended(bool suspend,
                                const base::TimeTicks& proceed_time);
 
   // Clears any suspended navigation state after a cross-site navigation is
   // canceled or suspended. This is important if we later return to this
   // RenderFrameHost.
   void CancelSuspendedNavigations();
 
   // Runs the beforeunload handler for this frame. |for_navigation| indicates
   // whether this call is for the current frame during a cross-process
-  // navigation. False means we're closing the entire tab.
+  // navigation. False means we're closing the entire tab. |is_reload|
+  // indicates whether the navigation is a reload of the page or a different

[nasko, 2016/05/09 21:56:04]

nit: s/or a different kind of navigation/or not/

[clamy, 2016/05/10 01:58:09]

Done.

+  // kind of navigation. If |for_navigation| is false, |is_reload| should be
+  // false as well.
   // PlzNavigate: this call happens on all browser-initiated navigations.
-  void DispatchBeforeUnload(bool for_navigation);
+  void DispatchBeforeUnload(bool for_navigation, bool is_reload);
 
   // Returns true if a call to DispatchBeforeUnload will actually send the
   // BeforeUnload IPC. This is the case if the current renderer is live and this
   // frame is the main frame.
   bool ShouldDispatchBeforeUnload();
 
   // Update the frame's opener in the renderer process in response to the
   // opener being modified (e.g., with window.open or being set to null) in
   // another renderer process.
   void UpdateOpener();
@@ skipping 557 matching lines @@
 
   // NOTE: This must be the last member.
   base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_