Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: ios/web/shell/test/utils/navigation_egutil.h

Issue 1890333002: Web shell test to go back and forward. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make webState a property Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/shell/test/utils/navigation_egutil.h
diff --git a/ios/web/shell/test/utils/navigation_egutil.h b/ios/web/shell/test/utils/navigation_egutil.h
new file mode 100644
index 0000000000000000000000000000000000000000..b38adbdc3325f702f36a0897c1a16f0167a22a14
--- /dev/null
+++ b/ios/web/shell/test/utils/navigation_egutil.h
@@ -0,0 +1,19 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_WEB_SHELL_TEST_NAVIGATION_EGUTIL_H_
+#define IOS_WEB_SHELL_TEST_NAVIGATION_EGUTIL_H_
baxley 2016/04/21 21:52:51 Note: this file was moved to navigation_test_util.
+
+#import "ios/web/shell/view_controller.h"
Eugene But (OOO till 7-30) 2016/04/21 17:07:52 Drop this
baxley 2016/04/21 21:52:51 Done.
+
+#include "url/gurl.h"
+
+namespace navigation_egutil {
Eugene But (OOO till 7-30) 2016/04/21 17:07:52 This should also be in web namespace
Eugene But (OOO till 7-30) 2016/04/21 17:07:52 There is nothing here related to Earl Grey. How ab
baxley 2016/04/21 21:52:51 Done.
baxley 2016/04/21 21:52:51 Done.
+
+// Load |url| in current webState.
Eugene But (OOO till 7-30) 2016/04/21 17:07:52 Please document that ui::PAGE_TRANSITION_TYPED tra
Eugene But (OOO till 7-30) 2016/04/21 17:07:52 s/Load/Loads
baxley 2016/04/21 21:52:51 Done.
baxley 2016/04/21 21:52:51 Done.
+void LoadURL(GURL url);
Eugene But (OOO till 7-30) 2016/04/21 17:07:52 According to C++ Style guide this should be LoadU
baxley 2016/04/21 21:52:51 Done.
+
+} // namespace navigation_egutil
+
+#endif // IOS_WEB_SHELL_TEST_NAVIGATION_EGUTIL_H_

Powered by Google App Engine
This is Rietveld 408576698