ios/web/shell/test/utils/navigation_egutil.h - Issue 1890333002: Web shell test to go back and forward.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/shell/test/utils/navigation_egutil.h

Issue 1890333002: Web shell test to go back and forward. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make webState a property Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/web/public/test/response_providers/html_response_provider.h ('K') | « ios/web/public/test/response_providers/html_response_provider_impl.mm ('k') | ios/web/shell/test/utils/navigation_egutil.mm » ('j') | ios/web/shell/test/utils/navigation_egutil.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_SHELL_TEST_NAVIGATION_EGUTIL_H_

	6 #define IOS_WEB_SHELL_TEST_NAVIGATION_EGUTIL_H_
	baxley 2016/04/21 21:52:51 Note: this file was moved to navigation_test_util. Note: this file was moved to navigation_test_util.h
	7

	8 #import "ios/web/shell/view_controller.h"
	Eugene But (OOO till 7-30) 2016/04/21 17:07:52 Drop this Drop this baxley 2016/04/21 21:52:51 Done. Show quoted text On 2016/04/21 17:07:52, Eugene But wrote: > Drop this Done.
	9

	10 #include "url/gurl.h"

	11

	12 namespace navigation_egutil {
	Eugene But (OOO till 7-30) 2016/04/21 17:07:52 This should also be in web namespace This should also be in web namespace Eugene But (OOO till 7-30) 2016/04/21 17:07:52 There is nothing here related to Earl Grey. How ab There is nothing here related to Earl Grey. How about navigation_test_util ? baxley 2016/04/21 21:52:51 Done. Show quoted text On 2016/04/21 17:07:52, Eugene But wrote: > This should also be in web namespace Done. baxley 2016/04/21 21:52:51 Done. Show quoted text On 2016/04/21 17:07:52, Eugene But wrote: > There is nothing here related to Earl Grey. How about navigation_test_util ? Done.
	13

	14 // Load \|url\| in current webState.
	Eugene But (OOO till 7-30) 2016/04/21 17:07:52 Please document that ui::PAGE_TRANSITION_TYPED tra Please document that ui::PAGE_TRANSITION_TYPED transition is used. Eugene But (OOO till 7-30) 2016/04/21 17:07:52 s/Load/Loads s/Load/Loads baxley 2016/04/21 21:52:51 Done. Show quoted text On 2016/04/21 17:07:52, Eugene But wrote: > s/Load/Loads Done. baxley 2016/04/21 21:52:51 Done. Show quoted text On 2016/04/21 17:07:52, Eugene But wrote: > Please document that ui::PAGE_TRANSITION_TYPED transition is used. Done.
	15 void LoadURL(GURL url);
	Eugene But (OOO till 7-30) 2016/04/21 17:07:52 According to C++ Style guide this should be LoadU According to C++ Style guide this should be LoadUrl baxley 2016/04/21 21:52:51 Done. Show quoted text On 2016/04/21 17:07:52, Eugene But wrote: > According to C++ Style guide this should be LoadUrl Done.
	16

	17 } // namespace navigation_egutil

	18

	19 #endif // IOS_WEB_SHELL_TEST_NAVIGATION_EGUTIL_H_

OLD	NEW