Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: ios/web/shell/test/shell_matchers.h

Issue 1890333002: Web shell test to go back and forward. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: few more updates Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/shell/test/shell_matchers.h
diff --git a/ios/web/shell/test/shell_matchers.h b/ios/web/shell/test/shell_matchers.h
new file mode 100644
index 0000000000000000000000000000000000000000..0ffa9decf4338851adf9c56c82ba8bc18eb27d80
--- /dev/null
+++ b/ios/web/shell/test/shell_matchers.h
@@ -0,0 +1,31 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <EarlGrey/EarlGrey.h>
+
+@interface GREYMatchers (WebShellAdditions)
+
+// Matcher for back button in web shell.
++ (id<GREYMatcher>)matcherForBackButton;
Eugene But (OOO till 7-30) 2016/04/21 22:53:08 Optional NIT: Maybe matcherForShellBackButton ?
baxley 2016/04/22 02:02:59 Done.
+
+// Matcher for forward button in web shell.
++ (id<GREYMatcher>)matcherForForwardButton;
+
+// Matcher for address field in web shell.
++ (id<GREYMatcher>)matcherForAddressField;
+
+@end
+
+#if !(GREY_DISABLE_SHORTHAND)
+
+// Shorthand for GREYMatchers::matcherForBackButton
Eugene But (OOO till 7-30) 2016/04/21 22:53:08 Optional NIT: Full stop at the end for consistency
baxley 2016/04/22 02:02:58 Done.
+GREY_EXPORT id<GREYMatcher> shell_backButton();
Eugene But (OOO till 7-30) 2016/04/21 22:53:08 NIT: I don't think we want to use GREY_EXPORT macr
baxley 2016/04/22 02:02:59 Are you okay with just using extern "C" {? Or do y
Eugene But (OOO till 7-30) 2016/04/22 02:33:29 That's a good point. In Chromium we have macros li
+
+// Shorthand for GREYMatchers::matcherForForwardButton
+GREY_EXPORT id<GREYMatcher> shell_forwardButton();
+
+// Shorthand for GREYMatchers::matcherForAddressField
+GREY_EXPORT id<GREYMatcher> shell_addressField();
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698