ios/web/shell/test/shell_matchers.h - Issue 1890333002: Web shell test to go back and forward.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/shell/test/shell_matchers.h

Issue 1890333002: Web shell test to go back and forward. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: few more updates Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/web/shell/test/navigation_test_util.mm ('K') | « ios/web/shell/test/navigation_test_util.mm ('k') | ios/web/shell/test/shell_matchers.mm » ('j') | ios/web/shell/test/web_shell_navigation_egtest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #import <EarlGrey/EarlGrey.h>

	6

	7 @interface GREYMatchers (WebShellAdditions)

	8

	9 // Matcher for back button in web shell.

	10 + (id<GREYMatcher>)matcherForBackButton;
	Eugene But (OOO till 7-30) 2016/04/21 22:53:08 Optional NIT: Maybe matcherForShellBackButton ? Optional NIT: Maybe matcherForShellBackButton ? baxley 2016/04/22 02:02:59 Done. Show quoted text On 2016/04/21 22:53:08, Eugene But wrote: > Optional NIT: Maybe matcherForShellBackButton ? Done.
	11

	12 // Matcher for forward button in web shell.

	13 + (id<GREYMatcher>)matcherForForwardButton;

	14

	15 // Matcher for address field in web shell.

	16 + (id<GREYMatcher>)matcherForAddressField;

	17

	18 @end

	19

	20 #if !(GREY_DISABLE_SHORTHAND)

	21

	22 // Shorthand for GREYMatchers::matcherForBackButton
	Eugene But (OOO till 7-30) 2016/04/21 22:53:08 Optional NIT: Full stop at the end for consistency Optional NIT: Full stop at the end for consistency? Here and in other 2 functions. baxley 2016/04/22 02:02:58 Done. Show quoted text On 2016/04/21 22:53:08, Eugene But wrote: > Optional NIT: Full stop at the end for consistency? Here and in other 2 > functions. Done.
	23 GREY_EXPORT id<GREYMatcher> shell_backButton();
	Eugene But (OOO till 7-30) 2016/04/21 22:53:08 NIT: I don't think we want to use GREY_EXPORT macr NIT: I don't think we want to use GREY_EXPORT macro, since this is not a part of EG framework. Just export sounds more appropriate. baxley 2016/04/22 02:02:59 Are you okay with just using extern "C" {? Or do y Show quoted text On 2016/04/21 22:53:08, Eugene But wrote: > NIT: I don't think we want to use GREY_EXPORT macro, since this is not a part of > EG framework. Just export sounds more appropriate. Are you okay with just using extern "C" {? Or do you want me to put a conditional for __cplusplus? Eugene But (OOO till 7-30) 2016/04/22 02:33:29 That's a good point. In Chromium we have macros li Show quoted text On 2016/04/22 02:02:59, baxley wrote: > On 2016/04/21 22:53:08, Eugene But wrote: > > NIT: I don't think we want to use GREY_EXPORT macro, since this is not a part > of > > EG framework. Just export sounds more appropriate. > > Are you okay with just using extern "C" {? Or do you want me to put a > conditional for __cplusplus? That's a good point. In Chromium we have macros like CONTENT_EXPORT and NET_EXPORT. So it makes sense to have WEB_EXPORT. And I'm fine if you do this in a separate CL.
	24

	25 // Shorthand for GREYMatchers::matcherForForwardButton

	26 GREY_EXPORT id<GREYMatcher> shell_forwardButton();

	27

	28 // Shorthand for GREYMatchers::matcherForAddressField

	29 GREY_EXPORT id<GREYMatcher> shell_addressField();

	30

	31 #endif

OLD	NEW