[iOS/Mac/GN] Hoist the public_configs for a framework bundle into the base template.

build/config/mac/rules.gni

Index: build/config/mac/rules.gni
diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index 4e9ea68fa1e7708009c4f746885b2f3be561a348..9ab140ed5a7792795ef42dad4eb99667ec968895 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -74,6 +74,18 @@ template("framework_bundle") {
     ]
   }
 
+  _framework_public_config = _target_name + "_public_config"
+  config(_framework_public_config) {
+    # TODO(sdefresne): should we have a framework_dirs similar to lib_dirs

[sdefresne, 2016/04/18 09:02:58]

nit: can you add visibility?

visibility = [ ":$_framework_target" ]

[Robert Sesek, 2016/04/18 15:13:09]

Done.

+    # and include_dirs to avoid duplicate values on the command-line.
+    common_flags = [ "-F" + rebase_path("$root_out_dir/.", root_out_dir) ]
+    cflags_objc = common_flags
+    cflags_objcc = common_flags
+    ldflags = common_flags
+    lib_dirs = [ root_out_dir ]
+    libs = [ _framework_name ]
+  }
+
   create_bundle(_framework_target) {
     forward_variables_from(invoker,
                            [
@@ -94,6 +106,11 @@ template("framework_bundle") {
     }
     public_deps += [ ":$_shared_library_bundle_data" ]
 
+    if (!defined(public_configs)) {

[sdefresne, 2016/04/18 09:02:58]

You do not forward the public_configs in "forward_variables_from" so, this
should not be defined and can be simplified to:

public_configs = [ ":$_framework_public_config" ]

[Robert Sesek, 2016/04/18 15:13:09]

Done.

+      public_configs = []
+    }
+    public_configs += [ ":$_framework_public_config" ]
+
     bundle_root_dir = _framework_root_dir
     bundle_resources_dir = "$bundle_root_dir/Resources"
     bundle_executable_dir = "$bundle_root_dir"