Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 1890253002: Observe gTreatSkColorAsSRGB for 4f gradients. (Closed)

Created:
4 years, 8 months ago by f(malita)
Modified:
4 years, 8 months ago
Reviewers:
herb_g, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Observe gTreatSkColorAsSRGB for 4f gradients. Use SkColor4f::FromColor() in the color packer to convert srgb->linear when needed. R=reed@google.com,herb@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1890253002 Committed: https://skia.googlesource.com/skia/+/b931336f3b7913e64602562d7d6d9187086bbd5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -33 lines) Patch
M src/effects/gradients/Sk4fGradientBase.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/gradients/Sk4fGradientBase.cpp View 5 chunks +26 lines, -30 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
f(malita)
4 years, 8 months ago (2016-04-15 19:50:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890253002/1
4 years, 8 months ago (2016-04-15 19:50:37 UTC) #4
reed1
4 years, 8 months ago (2016-04-15 19:59:50 UTC) #5
reed1
lgtm
4 years, 8 months ago (2016-04-15 19:59:55 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 20:01:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890253002/1
4 years, 8 months ago (2016-04-15 20:02:12 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 20:03:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b931336f3b7913e64602562d7d6d9187086bbd5a

Powered by Google App Engine
This is Rietveld 408576698