Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: ui/views/animation/ink_drop_hover_unittest.cc

Issue 1890243002: Expand the Material Design hover as it fades out when a ripple is triggered. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed ink_drop_hover_unittest.cc compile error. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/animation/ink_drop_hover_unittest.cc
diff --git a/ui/views/animation/ink_drop_hover_unittest.cc b/ui/views/animation/ink_drop_hover_unittest.cc
index c53e0470694cc39395951fe7b52248d993323188..586ed2ad2a07365b0ee63a1f7e0f3834af388a6b 100644
--- a/ui/views/animation/ink_drop_hover_unittest.cc
+++ b/ui/views/animation/ink_drop_hover_unittest.cc
@@ -53,7 +53,7 @@ TEST_F(InkDropHoverTest, IsHoveredStateTransitions) {
ink_drop_hover->FadeIn(base::TimeDelta::FromMilliseconds(0));
EXPECT_TRUE(ink_drop_hover->IsFadingInOrVisible());
- ink_drop_hover->FadeOut(base::TimeDelta::FromMilliseconds(0));
+ ink_drop_hover->FadeOut(base::TimeDelta::FromMilliseconds(0), false);
varkha 2016/04/21 16:16:49 nit: document what false does here. Maybe "false /
bruthig 2016/04/21 21:14:04 Done.
EXPECT_FALSE(ink_drop_hover->IsFadingInOrVisible());
}
« ui/views/animation/ink_drop_hover.cc ('K') | « ui/views/animation/ink_drop_hover.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698