Exclude simple headers when building Access-Control-Request-Headers

Exclude simple headers when building Access-Control-Request-Headers

As per https://github.com/whatwg/fetch/issues/249, we've change the
fetch algorithm to omit simple headers when building a CORS preflight
request.

BUG=601092
R=mkwst

Committed: https://crrev.com/34d19ec118192003bcc041fdea30cd7650411402
Cr-Commit-Position: refs/heads/master@{#388733}

[tyoshino (SeeGerritForStatus), 2016-04-15 07:30:03]

Description was changed from

==========
Exclude simple headers when building Access-Control-Request-Headers

As per https://github.com/whatwg/fetch/issues/249, we've change the
fetch algorithm to omit simple headers when building a CORS preflight
request.

BUG=601092
==========

to

==========
Exclude simple headers when building Access-Control-Request-Headers

As per https://github.com/whatwg/fetch/issues/249, we've change the
fetch algorithm to omit simple headers when building a CORS preflight
request.

BUG=601092
==========

[tyoshino (SeeGerritForStatus), 2016-04-15 07:30:03]

tyoshino@chromium.org changed reviewers:
+ mkwst@chromium.org

[tyoshino (SeeGerritForStatus), 2016-04-15 07:30:24]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 07:30:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890053002/40001

[commit-bot: I haz the power, 2016-04-15 09:58:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 09:58:32]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-04-15 11:40:03]

The code change LGTM. I would like to see some more tests, though. In
particular, please add:

1. Simple and non-simple values of `Content-Type`.

2. The specific headers excluded in `isSimpleHeader` (accept, accept-language,
content-language, save-data).

Basically, if `FetchUtils::isSimpleHeader` changes, a test somewhere should
break. :)

[tyoshino (SeeGerritForStatus), 2016-04-18 12:56:05]

On 2016/04/15 11:40:03, Mike West wrote:
> The code change LGTM. I would like to see some more tests, though. In
> particular, please add:
> 
> 1. Simple and non-simple values of `Content-Type`.
> 
> 2. The specific headers excluded in `isSimpleHeader` (accept, accept-language,
> content-language, save-data).
> 
> Basically, if `FetchUtils::isSimpleHeader` changes, a test somewhere should
> break. :)

Thanks for review, Mike. I've added unit tests for checking them. PTAL.

[Mike West, 2016-04-20 08:04:06]

Thank you, LGTM (again). :)

[tyoshino (SeeGerritForStatus), 2016-04-21 05:57:40]

Description was changed from

==========
Exclude simple headers when building Access-Control-Request-Headers

As per https://github.com/whatwg/fetch/issues/249, we've change the
fetch algorithm to omit simple headers when building a CORS preflight
request.

BUG=601092
==========

to

==========
Exclude simple headers when building Access-Control-Request-Headers

As per https://github.com/whatwg/fetch/issues/249, we've change the
fetch algorithm to omit simple headers when building a CORS preflight
request.

BUG=601092
R=mkwst
==========

[tyoshino (SeeGerritForStatus), 2016-04-21 05:57:45]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-04-21 05:57:46]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1890053002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-21 05:57:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890053002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890053002/100001

[commit-bot: I haz the power, 2016-04-21 10:09:55]

Description was changed from

==========
Exclude simple headers when building Access-Control-Request-Headers

As per https://github.com/whatwg/fetch/issues/249, we've change the
fetch algorithm to omit simple headers when building a CORS preflight
request.

BUG=601092
R=mkwst
==========

to

==========
Exclude simple headers when building Access-Control-Request-Headers

As per https://github.com/whatwg/fetch/issues/249, we've change the
fetch algorithm to omit simple headers when building a CORS preflight
request.

BUG=601092
R=mkwst
==========

[commit-bot: I haz the power, 2016-04-21 10:09:56]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-22 19:33:07]

Description was changed from

==========
Exclude simple headers when building Access-Control-Request-Headers

As per https://github.com/whatwg/fetch/issues/249, we've change the
fetch algorithm to omit simple headers when building a CORS preflight
request.

BUG=601092
R=mkwst
==========

to

==========
Exclude simple headers when building Access-Control-Request-Headers

As per https://github.com/whatwg/fetch/issues/249, we've change the
fetch algorithm to omit simple headers when building a CORS preflight
request.

BUG=601092
R=mkwst

Committed: https://crrev.com/34d19ec118192003bcc041fdea30cd7650411402
Cr-Commit-Position: refs/heads/master@{#388733}
==========

[commit-bot: I haz the power, 2016-04-22 19:33:08]

Patchset 6 (id:??) landed as
https://crrev.com/34d19ec118192003bcc041fdea30cd7650411402
Cr-Commit-Position: refs/heads/master@{#388733}