Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp

Issue 1890053002: Exclude simple headers when building Access-Control-Request-Headers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp b/third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..f5a2e59f6920fc741559ab9c162dce335c2f9880
--- /dev/null
+++ b/third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp
@@ -0,0 +1,86 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/fetch/CrossOriginAccessControl.h"
+
+#include "platform/network/ResourceRequest.h"
+#include "platform/weborigin/SecurityOrigin.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "wtf/RefPtr.h"
+#include "wtf/text/WTFString.h"
+
+namespace blink {
+
+namespace {
+
+class CreateAccessControlPreflightRequestTest : public ::testing::Test {
+protected:
+ virtual void SetUp()
+ {
+ m_securityOrigin = SecurityOrigin::createFromString("http://example.com");
+ }
+
+ RefPtr<SecurityOrigin> m_securityOrigin;
+};
+
+TEST_F(CreateAccessControlPreflightRequestTest, LexicographicalOrder)
+{
+ ResourceRequest request;
+ request.addHTTPHeaderField("Orange", "Orange");
+ request.addHTTPHeaderField("Apple", "Red");
+ request.addHTTPHeaderField("Kiwifruit", "Green");
+ request.addHTTPHeaderField("Content-Type", "application/octet-stream");
+ request.addHTTPHeaderField("Strawberry", "Red");
+
+ ResourceRequest preflight = createAccessControlPreflightRequest(request, m_securityOrigin.get());
+
+ EXPECT_EQ("apple, content-type, kiwifruit, orange, strawberry", preflight.httpHeaderField("Access-Control-Request-Headers"));
+}
+
+TEST_F(CreateAccessControlPreflightRequestTest, ExcludeSimpleHeaders)
+{
+ ResourceRequest request;
+ request.addHTTPHeaderField("Accept", "everything");
+ request.addHTTPHeaderField("Accept-Language", "everything");
+ request.addHTTPHeaderField("Content-Language", "everything");
+ request.addHTTPHeaderField("Save-Data", "on");
+
+ ResourceRequest preflight = createAccessControlPreflightRequest(request, m_securityOrigin.get());
+
+ EXPECT_EQ("", preflight.httpHeaderField("Access-Control-Request-Headers"));
+}
+
+TEST_F(CreateAccessControlPreflightRequestTest, ExcludeSimpleContentTypeHeader)
+{
+ ResourceRequest request;
+ request.addHTTPHeaderField("Content-Type", "text/plain");
+
+ ResourceRequest preflight = createAccessControlPreflightRequest(request, m_securityOrigin.get());
+
+ EXPECT_EQ("", preflight.httpHeaderField("Access-Control-Request-Headers"));
+}
+
+TEST_F(CreateAccessControlPreflightRequestTest, IncludeNonSimpleHeader)
+{
+ ResourceRequest request;
+ request.addHTTPHeaderField("X-Custom-Header", "foobar");
+
+ ResourceRequest preflight = createAccessControlPreflightRequest(request, m_securityOrigin.get());
+
+ EXPECT_EQ("x-custom-header", preflight.httpHeaderField("Access-Control-Request-Headers"));
+}
+
+TEST_F(CreateAccessControlPreflightRequestTest, IncludeNonSimpleContentTypeHeader)
+{
+ ResourceRequest request;
+ request.addHTTPHeaderField("Content-Type", "application/octet-stream");
+
+ ResourceRequest preflight = createAccessControlPreflightRequest(request, m_securityOrigin.get());
+
+ EXPECT_EQ("content-type", preflight.httpHeaderField("Access-Control-Request-Headers"));
+}
+
+} // namespace
+
+} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698