[mojo-edk] Support transferring null Mach ports.

[mojo-edk] Support transferring null Mach ports.

BUG=603452
Committed: https://crrev.com/7bd80f207b67368fe1d1b6dc6641406444ae6290
Cr-Commit-Position: refs/heads/master@{#387797}

[Anand Mistry (off Chromium), 2016-04-15 07:14:29]

amistry@chromium.org changed reviewers:
+ erikchen@chromium.org, rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-04-15 14:29:58]

lgtm

[erikchen, 2016-04-15 15:53:49]

https://codereview.chromium.org/1890043002/diff/1/mojo/edk/system/channel.cc
File mojo/edk/system/channel.cc (right):

https://codereview.chromium.org/1890043002/diff/1/mojo/edk/system/channel.cc#...
mojo/edk/system/channel.cc:104: mach_ports_header_->num_ports = 0;
why don't you set this straight to max_handles_?

Can you add a comment about the semantic meaning of the |num_ports| field?

[Anand Mistry (off Chromium), 2016-04-15 23:29:07]

https://codereview.chromium.org/1890043002/diff/1/mojo/edk/system/channel.cc
File mojo/edk/system/channel.cc (right):

https://codereview.chromium.org/1890043002/diff/1/mojo/edk/system/channel.cc#...
mojo/edk/system/channel.cc:104: mach_ports_header_->num_ports = 0;
On 2016/04/15 15:53:49, erikchen wrote:
> why don't you set this straight to max_handles_?
> 
Because this is the number of encoded Mach ports, and none have been set yet.

> Can you add a comment about the semantic meaning of the |num_ports| field? 
Done.

[erikchen, 2016-04-16 00:06:42]

lgtm

[Anand Mistry (off Chromium), 2016-04-16 00:39:34]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2016-04-16 00:39:35]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1890043002/#ps20001
(title: "Add header comments.")

[commit-bot: I haz the power, 2016-04-16 00:40:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890043002/20001

[commit-bot: I haz the power, 2016-04-16 02:25:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-16 02:26:52]

Description was changed from

==========
[mojo-edk] Support transferring null Mach ports.

BUG=603452
==========

to

==========
[mojo-edk] Support transferring null Mach ports.

BUG=603452

Committed: https://crrev.com/7bd80f207b67368fe1d1b6dc6641406444ae6290
Cr-Commit-Position: refs/heads/master@{#387797}
==========

[commit-bot: I haz the power, 2016-04-16 02:26:53]

Patchset 2 (id:??) landed as
https://crrev.com/7bd80f207b67368fe1d1b6dc6641406444ae6290
Cr-Commit-Position: refs/heads/master@{#387797}