Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 189003004: Fix install verification for sideloaded extensions without update urls (Closed)

Created:
6 years, 9 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fix install verification for sideloaded extensions without update urls We found that extensions which are sideloaded via the registry or other methods that had migrated to the webstore were not being verified because we weren't even asking the verification service about them. In order to fix this, this CL moves to an approach where we keep a list of not verified ids as well as verified ones, and if we encounter an id that isn't "known bad", we make sure to check with the server first instead of immediately refusing to load it. In testing this I also noticed and fixed a case where we were attempting to disable COMPONENT extensions (it isn't currently possible to disable them, but that could change someday so it seemed better not to try disabling them or adding them to the list of invalid ids). BUG=344937 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255554

Patch Set 1 #

Patch Set 2 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -43 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/install_signer.h View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/install_signer.cc View 8 chunks +56 lines, -17 lines 0 comments Download
M chrome/browser/extensions/install_verifier.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/install_verifier.cc View 1 8 chunks +27 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
asargent_no_longer_on_chrome
6 years, 9 months ago (2014-03-06 21:48:16 UTC) #1
Ken Rockot(use gerrit already)
On 2014/03/06 21:48:16, Antony Sargent wrote: lgtm
6 years, 9 months ago (2014-03-06 22:37:49 UTC) #2
asargent_no_longer_on_chrome
The CQ bit was checked by asargent@chromium.org
6 years, 9 months ago (2014-03-06 22:46:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/189003004/20001
6 years, 9 months ago (2014-03-06 22:50:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 00:34:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 00:34:30 UTC) #6
asargent_no_longer_on_chrome
The CQ bit was checked by asargent@chromium.org
6 years, 9 months ago (2014-03-07 00:42:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/189003004/20001
6 years, 9 months ago (2014-03-07 00:46:45 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 08:54:39 UTC) #9
Message was sent while issue was closed.
Change committed as 255554

Powered by Google App Engine
This is Rietveld 408576698