Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 189003004: Fix install verification for sideloaded extensions without update urls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/install_signer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index aabb758c24ce5caf300137e4f2bc2f6d0006f285..412787979dfcaaafdde066e447b0be43c581d696 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -614,20 +614,15 @@ void ExtensionService::MaybeBootstrapVerifier() {
if (verifier->NeedsBootstrap()) {
do_bootstrap = true;
} else {
- // If any of the installed extensions have an install time newer than the
- // signature's timestamp, we need to bootstrap because our signature may
- // be missing valid extensions.
- base::Time timestamp = verifier->SignatureTimestamp();
scoped_ptr<extensions::ExtensionSet> extensions =
GenerateInstalledExtensionsSet();
for (extensions::ExtensionSet::const_iterator i = extensions->begin();
i != extensions->end();
++i) {
const Extension& extension = **i;
- base::Time install_time =
- extension_prefs_->GetInstallTime(extension.id());
+
if (verifier->NeedsVerification(extension) &&
- install_time < base::Time::Now() && install_time >= timestamp) {
+ !verifier->IsKnownId(extension.id())) {
do_bootstrap = true;
break;
}
« no previous file with comments | « no previous file | chrome/browser/extensions/install_signer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698