third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp - Issue 1889973002: Refactoring starting a resource load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

Issue 1889973002: Refactoring starting a resource load (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a browser_test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

diff --git a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

index 66ff041c7ef7a209708e31d0afaadf6cfa4d7fc7..0e092f1a8060ab6bd021738fee8308d5e0b68567 100644

--- a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

+++ b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp

@@ -8,6 +8,7 @@

#include "core/css/CSSFontFace.h"

#include "core/css/CSSFontSelector.h"

#include "core/dom/Document.h"

+#include "core/fetch/ResourceFetcher.h"

#include "core/inspector/ConsoleMessage.h"

#include "core/loader/FrameLoaderClient.h"

#include "core/page/NetworkStateNotifier.h"

@@ -205,7 +206,7 @@ PassRefPtr<SimpleFontData> RemoteFontFaceSource::createLoadingFallbackFontData(c

void RemoteFontFaceSource::beginLoadIfNeeded()

{

if (m_fontSelector->document() && m_font->stillNeedsLoad()) {

- m_font->load(m_fontSelector->document()->fetcher());

+ m_fontSelector->document()->fetcher()->startLoad(m_font);

m_histograms.loadStarted();

}

m_font->startLoadLimitTimersIfNeeded();