third_party/WebKit/Source/core/css/CSSImageValue.cpp - Issue 1889973002: Refactoring starting a resource load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSImageValue.cpp

Issue 1889973002: Refactoring starting a resource load (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a browser_test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp ('k') | third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSImageValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSImageValue.cpp b/third_party/WebKit/Source/core/css/CSSImageValue.cpp

index 9185fe3fddbdebf32f60205ba100db95d56203b7..e690c875edb3aafd55d201281a0270c055b37e02 100644

--- a/third_party/WebKit/Source/core/css/CSSImageValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSImageValue.cpp

@@ -92,7 +92,7 @@ void CSSImageValue::restoreCachedResourceIfNeeded(Document& document) const

FetchRequest request(ResourceRequest(m_absoluteURL), m_initiatorName.isEmpty() ? FetchInitiatorTypeNames::css : m_initiatorName, resource->options());

MixedContentChecker::shouldBlockFetch(document.frame(), resource->lastResourceRequest(),

resource->lastResourceRequest().url(), MixedContentChecker::SendReport);

- document.fetcher()->requestLoadStarted(resource, request, ResourceFetcher::ResourceLoadingFromCache);

+ document.fetcher()->requestLoadStarted(resource->identifier(), resource, request, ResourceFetcher::ResourceLoadingFromCache);

}

bool CSSImageValue::hasFailedOrCanceledSubresources() const