Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 2b3e0a437a3d5d2ef7fd03ae63e7c67d2880695f..43ce14d30c9d9c9293531c1e8c0448e517b0d121 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -6748,6 +6748,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| enum="DataReductionProxyAutoLoFiAccuracy"> |
| <owner>bengr@chromium.org</owner> |
| <owner>tbansal@chromium.org</owner> |
| + <obsolete> |
| + Obsoleted in April 2016. |
| + </obsolete> |
| <summary> |
| Counts the accuracy of estimated network quality when using Lo-Fi. Counters |
| are incremented when a main frame URL request is handled by Data Reduction |
| @@ -7108,6 +7111,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <summary>Size of Data Reduction Proxy LevelDB measured at startup.</summary> |
| </histogram> |
| +<histogram name="DataReductionProxy.LoFi.Accuracy" |
| + enum="DataReductionProxyAutoLoFiAccuracy"> |
| + <owner>bengr@chromium.org</owner> |
| + <owner>tbansal@chromium.org</owner> |
| + <summary> |
| + Records the accuracy of estimated network quality when using Lo-Fi. Network |
| + quality predicted at the time of navigation start is compared with the |
| + network quality observed during the specified time interval following the |
| + start of the navigation. This metric is recorded only when the session is in |
| + Lo-Fi enabled field trial. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="DataReductionProxy.LoFi.ImplicitOptOutAction" |
| enum="DataReductionProxyLoFiImplicitOptOutAction"> |
| <owner>bengr@chromium.org</owner> |
| @@ -88239,6 +88255,18 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <affected-histogram name="PLT.PT_StartToFinish"/> |
| </histogram_suffixes> |
| +<histogram_suffixes |
| + name="DataReductionProxy.LoFi.Accuracy.DifferentRecordingIntervals" |
| + separator="."> |
| + <suffix name="15" |
| + label="Recorded approximately 15 seconds after navigation start"/> |
| + <suffix name="30" |
| + label="Recorded approximately 30 seconds after navigation start"/> |
| + <suffix name="60" |
| + label="Recorded approximately 60 seconds after navigation start"/> |
| + <affected-histogram name="DataReductionProxy.LoFi.Accuracy"/> |
| +</histogram_suffixes> |
| + |
| <histogram_suffixes name="DataReductionProxy.MimeType"> |
| <suffix name="Application" label="Application mime-type"/> |
| <suffix name="Unknown" |
| @@ -88268,11 +88296,29 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <suffix name="4G" label="On 4G network"/> |
| <suffix name="None" label="With no detected network"/> |
| <suffix name="Bluetooth" label="On Bluetooth network"/> |
| - <affected-histogram name="DataReductionProxy.AutoLoFiAccuracy"/> |
|
Alexei Svitkine (slow)
2016/04/18 20:35:09
Mark the suffix as <obsolete>. See for e.g. Create
tbansal1
2016/04/18 22:37:35
Done. Thanks, I was not sure if I could deprecate
|
| <affected-histogram name="DataReductionProxy.AutoLoFiRequestHeaderState"/> |
| + <affected-histogram name="DataReductionProxy.LoFi.Accuracy.15"/> |
| + <affected-histogram name="DataReductionProxy.LoFi.Accuracy.30"/> |
| + <affected-histogram name="DataReductionProxy.LoFi.Accuracy.60"/> |
| <affected-histogram name="DataReductionProxy.LoFi.ImplicitOptOutAction"/> |
| </histogram_suffixes> |
| +<histogram_suffixes name="DataReductionProxy.NetworkTypes.Obsoleted" |
| + separator="."> |
| + <obsolete> |
| + Obsoleted |
| + </obsolete> |
| + <suffix name="Unknown" label="On Unknown network"/> |
| + <suffix name="Ethernet" label="On Ethernet network"/> |
| + <suffix name="WiFi" label="On WiFi network"/> |
| + <suffix name="2G" label="On 2G network"/> |
| + <suffix name="3G" label="On 3G Network"/> |
| + <suffix name="4G" label="On 4G network"/> |
| + <suffix name="None" label="With no detected network"/> |
| + <suffix name="Bluetooth" label="On Bluetooth network"/> |
| + <affected-histogram name="DataReductionProxy.AutoLoFiAccuracy"/> |
| +</histogram_suffixes> |
| + |
| <histogram_suffixes name="DataReductionProxy.WithValidOCL.LoFiOn" separator="."> |
| <suffix name="LoFiOn" |
| label="Only page loads through the data reduction proxy with Lo-Fi On |