Record Lo-Fi NQE prediction accuracy at different intervals

components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
index 5f994a8348e88a2a823a1be1b1e1198470d3ac1c..3d4b443694d060d66494d75339eb467ada498600 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
@@ -6,11 +6,19 @@
 #define COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_CONFIG_TEST_UTILS_H_
 
 #include <memory>
+#include <vector>
 
+#include "base/memory/ref_counted.h"
+#include "base/time/time.h"
 #include "components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h"
 #include "net/base/network_interfaces.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
+namespace base {
+class SingleThreadTaskRunner;
+class TickClock;
+}
+
 namespace net {
 class NetworkQualityEstimator;
 class NetLog;
@@ -33,6 +41,7 @@ class TestDataReductionProxyConfig : public DataReductionProxyConfig {
   TestDataReductionProxyConfig(
       int params_flags,
       unsigned int params_definitions,
+      scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
       net::NetLog* net_log,
       DataReductionProxyConfigurator* configurator,
       DataReductionProxyEventCreator* event_creator);
@@ -42,6 +51,7 @@ class TestDataReductionProxyConfig : public DataReductionProxyConfig {
   // DataReductionProxyParams or DataReductionProxyMutableConfigValues).
   TestDataReductionProxyConfig(
       std::unique_ptr<DataReductionProxyConfigValues> config_values,
+      scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
       net::NetLog* net_log,
       DataReductionProxyConfigurator* configurator,
       DataReductionProxyEventCreator* event_creator);
@@ -81,11 +91,27 @@ class TestDataReductionProxyConfig : public DataReductionProxyConfig {
     return network_interfaces_.get();
   }
 
+  void set_lofi_accuracy_recording_intervals(
+      const std::vector<base::TimeDelta>& lofi_accuracy_recording_intervals);

[Alexei Svitkine (slow), 2016/04/18 20:35:09]

Nit: trivial setters/getters using hacker_style convention should be defined
inline. So either define inline or use CamelCase.

[tbansal1, 2016/04/18 22:37:35]

Done.

+
+  const std::vector<base::TimeDelta>& lofi_accuracy_recording_intervals()
+      const override;

[Alexei Svitkine (slow), 2016/04/18 20:35:09]

Nit: I think virtual functions shouldn't be using hacker_style syntax.

[tbansal1, 2016/04/18 22:37:35]

Right, virtual functions can't be inline.

+
+  void set_tick_clock(base::TickClock* tick_clock);

[Alexei Svitkine (slow), 2016/04/18 20:35:09]

Nit: Same comment as set_lofi_accuracy_recording_intervals().

[tbansal1, 2016/04/18 22:37:35]

Done.

+
+  base::TickClock* GetTickClock() const override;
+
  private:
+  base::TickClock* tick_clock_;
+
   std::unique_ptr<net::NetworkInterfaceList> network_interfaces_;
 
-  // True if network quality is slow enough to turn Auto Lo-Fi ON.
+  bool network_quality_prohibitively_slow_set_;
+  // True if the network quality is slow enough to turn Lo-Fi ON.
   bool network_quality_prohibitively_slow_;
+
+  bool lofi_accuracy_recording_intervals_set_;
+  std::vector<base::TimeDelta> lofi_accuracy_recording_intervals_;
 };

[Alexei Svitkine (slow), 2016/04/18 20:35:09]

Nit: DISALLOW_COPY_AND_ASSIGN().

[tbansal1, 2016/04/18 22:37:35]

Done.

 
 // A |TestDataReductionProxyConfig| which permits mocking of methods for
@@ -95,6 +121,7 @@ class MockDataReductionProxyConfig : public TestDataReductionProxyConfig {
   // Creates a |MockDataReductionProxyConfig|.
   MockDataReductionProxyConfig(
       std::unique_ptr<DataReductionProxyConfigValues> config_values,
+      scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
       net::NetLog* net_log,
       DataReductionProxyConfigurator* configurator,
       DataReductionProxyEventCreator* event_creator);