core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp - Issue 1889863002: Make CPDF_Dictionary methods take CFX_ByteString arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

Issue 1889863002: Make CPDF_Dictionary methods take CFX_ByteString arguments (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: One last caller. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp b/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

index 16daba184db6cb65434764d7e2a2a80d7e55c317..5c3398d50a9784db60f962eff28837125ebfb3c8 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp

@@ -590,7 +590,7 @@ CPDF_Object* CPDF_SyntaxParser::GetObjectByStrict(

}

if (key.GetLength() > 1) {

- pDict->SetAt(CFX_ByteStringC(key.c_str() + 1, key.GetLength() - 1),

+ pDict->SetAt(CFX_ByteString(key.c_str() + 1, key.GetLength() - 1),

obj.release());

}