core/fpdfapi/fpdf_parser/cpdf_parser.cpp - Issue 1889863002: Make CPDF_Dictionary methods take CFX_ByteString arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_parser.cpp

Issue 1889863002: Make CPDF_Dictionary methods take CFX_ByteString arguments (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: One last caller. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_parser.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_parser.cpp b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

index d6531f51842bae781c55986250d8236010f1500b..7fed6a380c65e3c5ff22ca00c52342a5c5e643bd 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

@@ -822,11 +822,10 @@ FX_BOOL CPDF_Parser::RebuildCrossRef() {

uint32_t dwObjNum =

pElement ? pElement->GetObjNum() : 0;

if (dwObjNum) {

- m_pTrailer->SetAtReference(key.AsStringC(),

- m_pDocument, dwObjNum);

+ m_pTrailer->SetAtReference(key, m_pDocument,

+ dwObjNum);

} else {

- m_pTrailer->SetAt(key.AsStringC(),

- pElement->Clone());

+ m_pTrailer->SetAt(key, pElement->Clone());

}