Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1889813002: Revert of Add test case for OpenTypeCapsSupport (Closed)

Created:
4 years, 8 months ago by drott
Modified:
4 years, 8 months ago
Reviewers:
kojii, eae
CC:
Dirk Pranke, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@openTypeCapsSupportNoTest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add test case for OpenTypeCapsSupport (patchset #1 id:1 of https://codereview.chromium.org/1885963005/ ) Reason for revert: Breaks blink_platform unittests on Linux: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux Original issue's description: > Add test case for OpenTypeCapsSupport > > This adds the test separately, after previous attempts to land > this had failed with issues in the swarming/isolate setup, see > https://codereview.chromium.org/1891613002/ . > > Landing this separately will help us analyse why files are not > available in the swarming step of running blink_platform_unittests > or what the root cause is. > > BUG=587094 > R=eae,kojii > > Committed: https://crrev.com/51428c9a0c963278a185d007af34c0d68f57e762 > Cr-Commit-Position: refs/heads/master@{#387267} TBR=eae@chromium.org,kojii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587094 Committed: https://crrev.com/77e8fb44b3f62474b0459ce1ce58c45d17055f8d Cr-Commit-Position: refs/heads/master@{#387292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -116 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_unittests.isolate View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportTest.cpp View 1 chunk +0 lines, -113 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
drott
Created Revert of Add test case for OpenTypeCapsSupport
4 years, 8 months ago (2016-04-14 12:25:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889813002/1
4 years, 8 months ago (2016-04-14 12:25:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 12:25:58 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/77e8fb44b3f62474b0459ce1ce58c45d17055f8d Cr-Commit-Position: refs/heads/master@{#387292}
4 years, 8 months ago (2016-04-14 12:27:37 UTC) #5
drott
4 years, 8 months ago (2016-04-14 12:43:21 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698