Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 1889743002: recipe lint test use custom recipe deps location. (Closed)

Created:
4 years, 8 months ago by martiniss
Modified:
4 years, 8 months ago
Reviewers:
dnj, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

recipe lint test use custom recipe deps location. breaking presubmit :/ Depends on https://codereview.chromium.org/1887653003 BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M scripts/slave/unittests/recipe_lint_test.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
martiniss
PTAL
4 years, 8 months ago (2016-04-14 00:57:04 UTC) #3
iannucci
lgtm
4 years, 8 months ago (2016-04-14 00:58:44 UTC) #4
dnj
lgtm, except DO NOT LAND this until you've added this new directory to PRESUBMIT blacklist.
4 years, 8 months ago (2016-04-14 01:24:34 UTC) #5
martiniss
On 2016/04/14 at 01:24:34, dnj wrote: > lgtm, except DO NOT LAND this until you've ...
4 years, 8 months ago (2016-04-14 02:07:32 UTC) #6
dnj
On 2016/04/14 02:07:32, martiniss wrote: > On 2016/04/14 at 01:24:34, dnj wrote: > > lgtm, ...
4 years, 8 months ago (2016-04-14 02:21:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889743002/1
4 years, 8 months ago (2016-04-14 02:39:01 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 02:44:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299920

Powered by Google App Engine
This is Rietveld 408576698