Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1887653003: Fix deps_path not being absolute. (Closed)

Created:
4 years, 8 months ago by martiniss
Modified:
4 years, 8 months ago
Reviewers:
dnj, iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M recipe_engine/package.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
martiniss
PTAL (needed for https://codereview.chromium.org/1889743002)
4 years, 8 months ago (2016-04-14 00:56:43 UTC) #2
iannucci
lgtm
4 years, 8 months ago (2016-04-14 00:57:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887653003/1
4 years, 8 months ago (2016-04-14 01:05:09 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 01:07:24 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/86dfd541045ff43443161327b88e8074fc9...

Powered by Google App Engine
This is Rietveld 408576698