Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1889673002: Move LayoutAndPaintAsyncThen to a separate compilation unit. (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LayoutAndPaintAsyncThen to a separate compilation unit. Moving LayoutAndPaintAsyncThen to a separate compilation unit is desirable, because: 1. It helps remove code from WebTestProxyBase (WebTestProxy should delegate everything to WebViewTestClient and/or [future] WebWidgetTestClient). 2. It helps break TestRunner -> WebTestProxyBase dependency and remove TestRunner::proxy_ field. BUG=595089 Committed: https://crrev.com/f41da4bd6ff9f8dd8a8d6e3e1416d539c8377b5a Cr-Commit-Position: refs/heads/master@{#387452}

Patch Set 1 #

Patch Set 2 : Self-review. #

Patch Set 3 : Fixed debug build. #

Patch Set 4 : Really fixing debug build... #

Patch Set 5 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -96 lines) Patch
M components/test_runner/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/test_runner/layout_and_paint_async_then.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
A components/test_runner/layout_and_paint_async_then.cc View 1 1 chunk +60 lines, -0 lines 0 comments Download
M components/test_runner/test_interfaces.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M components/test_runner/test_runner.h View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M components/test_runner/test_runner.cc View 1 2 3 4 8 chunks +10 lines, -9 lines 0 comments Download
M components/test_runner/test_runner.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/web_test_proxy.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 2 3 4 2 chunks +0 lines, -72 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
Łukasz Anforowicz
jochen@, could you please take a look?
4 years, 8 months ago (2016-04-14 00:54:54 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-14 13:27:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889673002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889673002/60001
4 years, 8 months ago (2016-04-14 13:51:43 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 14:32:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889673002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889673002/60001
4 years, 8 months ago (2016-04-14 20:21:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/168778)
4 years, 8 months ago (2016-04-14 20:30:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889673002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889673002/80001
4 years, 8 months ago (2016-04-14 21:11:58 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-14 22:33:32 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 22:35:48 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f41da4bd6ff9f8dd8a8d6e3e1416d539c8377b5a
Cr-Commit-Position: refs/heads/master@{#387452}

Powered by Google App Engine
This is Rietveld 408576698