Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1886103002: Move DumpBackForwardLists out of WebTestProxyBase. (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@separate-layout-and-paint-async-then
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DumpBackForwardLists out of WebTestProxyBase. Iterating over all known test windows can be moved out of web_test_proxy_base.cc and into blink_test_runner.cc. This helps minimize the amount of code in WebTestProxyBase (which should hopefully be just a passive holder of WebView, WebViewTestClient, etc. - all logic should be implemented inside WebViewTestClient and [future] WebWidgetTestClient). BUG=595089 Committed: https://crrev.com/7ab191b81769178cbbe438736b0144783ca40b49 Cr-Commit-Position: refs/heads/master@{#387465}

Patch Set 1 #

Patch Set 2 : Fixed debug build... :-/ #

Patch Set 3 : Rebasing... #

Patch Set 4 : Rebasing... #

Patch Set 5 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -30 lines) Patch
M components/test_runner/web_test_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/test_runner/web_test_interfaces.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/test_runner/web_test_interfaces.cc View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M components/test_runner/web_test_proxy.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 2 3 4 2 chunks +0 lines, -18 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
Łukasz Anforowicz
jochen@, could you please take a look?
4 years, 8 months ago (2016-04-14 00:55:29 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-14 13:27:20 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886103002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886103002/80001
4 years, 8 months ago (2016-04-14 21:16:05 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 22:29:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886103002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886103002/80001
4 years, 8 months ago (2016-04-14 22:37:56 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-14 22:43:34 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 22:44:37 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7ab191b81769178cbbe438736b0144783ca40b49
Cr-Commit-Position: refs/heads/master@{#387465}

Powered by Google App Engine
This is Rietveld 408576698