Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1889643002: S390:[simulator] Fix int64_t printf + minor cleanup (Closed)

Created:
4 years, 8 months ago by JoranSiu
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390:[simulator] Fix int64_t printf + minor cleanup * Use proper int64_t printf format qualifier to fix 64-bit sim compile on Mac. * Minor cleanup to ExecuteInstruction() to remove an unncessary 'processed' variable. R=jyan@ca.ibm.com,mbrandy@us.ibm.com,michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/a9817c6846f995cc458d963e6e89e35d9d6b9731 Cr-Commit-Position: refs/heads/master@{#35460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M src/s390/simulator-s390.cc View 1 chunk +10 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889643002/1
4 years, 8 months ago (2016-04-13 20:54:24 UTC) #2
JoranSiu
PTAL
4 years, 8 months ago (2016-04-13 20:58:25 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 21:11:58 UTC) #5
john.yan
lgtm
4 years, 8 months ago (2016-04-13 23:32:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889643002/1
4 years, 8 months ago (2016-04-14 01:20:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 01:22:26 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 01:23:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9817c6846f995cc458d963e6e89e35d9d6b9731
Cr-Commit-Position: refs/heads/master@{#35460}

Powered by Google App Engine
This is Rietveld 408576698