Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: src/s390/simulator-s390.cc

Issue 1889643002: S390:[simulator] Fix int64_t printf + minor cleanup (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/s390/simulator-s390.cc
diff --git a/src/s390/simulator-s390.cc b/src/s390/simulator-s390.cc
index 06e52a7626e78ee742647caf57656c5500d3cf6d..bc058ab63e0517d54ce67d11cfac97dd890e4b6f 100644
--- a/src/s390/simulator-s390.cc
+++ b/src/s390/simulator-s390.cc
@@ -4807,41 +4807,33 @@ void Simulator::ExecuteInstruction(Instruction* instr, bool auto_incr_pc) {
if (v8::internal::FLAG_check_icache) {
CheckICache(isolate_->simulator_i_cache(), instr);
}
+
pc_modified_ = false;
+
if (::v8::internal::FLAG_trace_sim) {
disasm::NameConverter converter;
disasm::Disassembler dasm(converter);
// use a reasonably large buffer
v8::internal::EmbeddedVector<char, 256> buffer;
dasm.InstructionDecode(buffer, reinterpret_cast<byte*>(instr));
-#ifdef V8_TARGET_ARCH_S390X
- PrintF("%05ld %08" V8PRIxPTR " %s\n", icount_,
- reinterpret_cast<intptr_t>(instr), buffer.start());
-#else
- PrintF("%05lld %08" V8PRIxPTR " %s\n", icount_,
+ PrintF("%05" PRId64 " %08" V8PRIxPTR " %s\n", icount_,
reinterpret_cast<intptr_t>(instr), buffer.start());
-#endif
+
// Flush stdout to prevent incomplete file output during abnormal exits
// This is caused by the output being buffered before being written to file
fflush(stdout);
}
- // Try to simulate as S390 Instruction first.
- bool processed = true;
-
int instrLength = instr->InstructionLength();
if (instrLength == 2)
- processed = DecodeTwoByte(instr);
+ DecodeTwoByte(instr);
else if (instrLength == 4)
- processed = DecodeFourByte(instr);
- else if (instrLength == 6)
- processed = DecodeSixByte(instr);
+ DecodeFourByte(instr);
+ else
+ DecodeSixByte(instr);
- if (processed) {
- if (!pc_modified_ && auto_incr_pc) {
- set_pc(reinterpret_cast<intptr_t>(instr) + instrLength);
- }
- return;
+ if (!pc_modified_ && auto_incr_pc) {
+ set_pc(reinterpret_cast<intptr_t>(instr) + instrLength);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698