Fix background compilation disassembly: allocate string in old space instead of new space.

Fix background compilation disassembly: allocate string in old space instead of new space.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/8a1072e3e6aa8f72f5628c370020cb8f1b35e827

[srdjan, 2016-04-13 19:58:36]

srdjan@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-04-13 20:29:48]

LGTM with one comment.

https://codereview.chromium.org/1889603003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1889603003/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:13746: return Symbols::FromConcat(thread,
Symbols::StubPrefix(), stub_name);
Why not do:

char* stub_name = OS::Screate(zone, "%s%s", Symbols::StubPrefix().ToCString(),
name);
return Symbols::New(thread, stub_name, strlen(stub_name));

[srdjan, 2016-04-13 20:38:16]

https://codereview.chromium.org/1889603003/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1889603003/diff/1/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:13746: return Symbols::FromConcat(thread,
Symbols::StubPrefix(), stub_name);
On 2016/04/13 20:29:48, siva wrote:
> Why not do:
> 
> char* stub_name = OS::Screate(zone, "%s%s", Symbols::StubPrefix().ToCString(),
> name);
> return Symbols::New(thread, stub_name, strlen(stub_name));

Done.

[srdjan, 2016-04-13 20:48:40]

Description was changed from

==========
Fix background compilation disassembly: allocate string in old space instead of
new space.

BUG=
==========

to

==========
Fix background compilation disassembly: allocate string in old space instead of
new space.

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8a1072e3e6aa8f72f5628c370020cb8f1b35e827
==========

[srdjan, 2016-04-13 20:48:42]

Committed patchset #2 (id:20001) manually as
8a1072e3e6aa8f72f5628c370020cb8f1b35e827 (presubmit successful).