Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: runtime/vm/object.cc

Issue 1889603003: Fix background compilation disassembly: allocate string in old space instead of new space. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index c3d120aea325af253e326b3b8fa4edaf1b809b5c..3b16b3312b2132d24fca362b319be54eab98ed61 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -13798,8 +13798,9 @@ RawString* Code::Name() const {
Zone* zone = thread->zone();
const char* name = StubCode::NameOfStub(EntryPoint());
ASSERT(name != NULL);
- const String& stub_name = String::Handle(zone, String::New(name));
- return Symbols::FromConcat(thread, Symbols::StubPrefix(), stub_name);
+ char* stub_name = OS::SCreate(zone,
+ "%s%s", Symbols::StubPrefix().ToCString(), name);
+ return Symbols::New(thread, stub_name, strlen(stub_name));
} else if (obj.IsClass()) {
// Allocation stub.
Thread* thread = Thread::Current();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698