Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1889583003: Revert of OOPIF: Fix subframe back/forward after recreating FTNs. (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
Reviewers:
alexmos
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of OOPIF: Fix subframe back/forward after recreating FTNs. (patchset #6 id:100001 of https://codereview.chromium.org/1816763002/ ) Reason for revert: This appears to have caused browser crashes in https://crbug.com/603245. Original issue's description: > OOPIF: Fix subframe back/forward after recreating FTNs. > > In some cases, we would navigate the main frame when going back/forward > in a subframe. This was because the FTN ID had changed from what was > stored in the FrameNavigationEntry. We can now use the frame's unique > name to find the FrameNavigationEntry as well. > > Also relaxes the restriction that a FrameNavigationEntry's item and > document sequence numbers don't change, at least until > https://crbug.com/596707 is fixed. > > BUG=586324, 568768 > TEST=See bug for repro steps. > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/273cbf61991e5339108de04c8a51fdb00a0916d5 > Cr-Commit-Position: refs/heads/master@{#386756} TBR=alexmos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=586324, 568768 Committed: https://crrev.com/e7b0a15f687a1a5efe0d6c2c8fc68b4d0b472bcb Cr-Commit-Position: refs/heads/master@{#387126}

Patch Set 1 #

Messages

Total messages: 7 (1 generated)
Charlie Reis
Created Revert of OOPIF: Fix subframe back/forward after recreating FTNs.
4 years, 8 months ago (2016-04-13 21:20:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889583003/1
4 years, 8 months ago (2016-04-13 21:20:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889583003/1
4 years, 8 months ago (2016-04-13 21:31:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889583003/1
4 years, 8 months ago (2016-04-13 22:01:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 22:30:11 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 22:31:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7b0a15f687a1a5efe0d6c2c8fc68b4d0b472bcb
Cr-Commit-Position: refs/heads/master@{#387126}

Powered by Google App Engine
This is Rietveld 408576698