Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: content/browser/frame_host/frame_navigation_entry.cc

Issue 1889583003: Revert of OOPIF: Fix subframe back/forward after recreating FTNs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_navigation_entry.cc
diff --git a/content/browser/frame_host/frame_navigation_entry.cc b/content/browser/frame_host/frame_navigation_entry.cc
index 0889b48387d2848ce40450b281f9d670f281416c..fe8809c8fc648d69d48c394beb7269085464b242 100644
--- a/content/browser/frame_host/frame_navigation_entry.cc
+++ b/content/browser/frame_host/frame_navigation_entry.cc
@@ -59,14 +59,17 @@
void FrameNavigationEntry::set_item_sequence_number(
int64_t item_sequence_number) {
- // TODO(creis): Assert that this does not change after being assigned, once
- // location.replace is classified as NEW_PAGE rather than EXISTING_PAGE.
- // Same for document sequence number. See https://crbug.com/596707.
+ // Once assigned, the item sequence number shouldn't change.
+ DCHECK(item_sequence_number_ == -1 ||
+ item_sequence_number_ == item_sequence_number);
item_sequence_number_ = item_sequence_number;
}
void FrameNavigationEntry::set_document_sequence_number(
int64_t document_sequence_number) {
+ // Once assigned, the document sequence number shouldn't change.
+ DCHECK(document_sequence_number_ == -1 ||
+ document_sequence_number_ == document_sequence_number);
document_sequence_number_ = document_sequence_number;
}
« no previous file with comments | « no previous file | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698