Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/push_messaging/background_budget_service_unittest.cc

Issue 1889513004: Make BackgroundBudgetService a KeyedService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ses_integration
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/push_messaging/background_budget_service_unittest.cc
diff --git a/chrome/browser/push_messaging/background_budget_service_unittest.cc b/chrome/browser/push_messaging/background_budget_service_unittest.cc
index 9aa17f13b1904eda25e9f2cb8235c2e4455703a4..868d1b215d574e5add14aebc24ea0a89a158c9dd 100644
--- a/chrome/browser/push_messaging/background_budget_service_unittest.cc
+++ b/chrome/browser/push_messaging/background_budget_service_unittest.cc
@@ -7,6 +7,7 @@
#include "chrome/browser/engagement/site_engagement_service.h"
#include "chrome/browser/push_messaging/background_budget_service.h"
+#include "chrome/browser/push_messaging/background_budget_service_factory.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -40,7 +41,9 @@ TEST_F(BackgroundBudgetServiceTest, GetBudgetNoBudgetOrSES) {
const GURL origin(kTestOrigin);
double budget = 0.0;
- BackgroundBudgetService::GetBudget(profile(), origin, budget);
+ BackgroundBudgetService* service =
+ BackgroundBudgetServiceFactory::GetForProfile(profile());
+ service->GetBudget(origin, budget);
EXPECT_EQ(budget, 0.0);
}
@@ -52,7 +55,9 @@ TEST_F(BackgroundBudgetServiceTest, GetBudgetNoBudgetSESExists) {
SetSiteEngagementScore(origin, kTestSES);
double budget = 0.0;
- BackgroundBudgetService::GetBudget(profile(), origin, budget);
+ BackgroundBudgetService* service =
+ BackgroundBudgetServiceFactory::GetForProfile(profile());
+ service->GetBudget(origin, budget);
EXPECT_EQ(budget, kTestSES);
}
@@ -60,10 +65,12 @@ TEST_F(BackgroundBudgetServiceTest, GetBudgetNoBudgetSESExists) {
TEST_F(BackgroundBudgetServiceTest, GetBudgetNoElapsedTime) {
const GURL origin(kTestOrigin);
- BackgroundBudgetService::StoreBudget(profile(), origin, kTestBudget);
+ BackgroundBudgetService* service =
+ BackgroundBudgetServiceFactory::GetForProfile(profile());
+ service->StoreBudget(origin, kTestBudget);
double budget = 0.0;
- BackgroundBudgetService::GetBudget(profile(), origin, budget);
+ service->GetBudget(origin, budget);
EXPECT_EQ(budget, kTestBudget);
}

Powered by Google App Engine
This is Rietveld 408576698