Make BackgroundBudgetService a KeyedService

chrome/browser/push_messaging/background_budget_service_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <string>
 
 #include "chrome/browser/engagement/site_engagement_service.h"
 #include "chrome/browser/push_messaging/background_budget_service.h"
+#include "chrome/browser/push_messaging/background_budget_service_factory.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 const char kTestOrigin[] = "https://example.com";
 const double kTestBudget = 10.0;
 const double kTestSES = 24.0;
 
 }  // namespace
 
 class BackgroundBudgetServiceTest : public testing::Test {
  public:
   BackgroundBudgetServiceTest() {}
   ~BackgroundBudgetServiceTest() override {}
 
   TestingProfile* profile() { return &profile_; }

[Michael van Ouwerkerk, 2016/04/14 14:36:31]

It seems a service() method instead of a profile() method would reduce verbosity
a lot.

[harkness, 2016/04/14 17:44:19]

Done.

 
   void SetSiteEngagementScore(const GURL& url, double score) {
     SiteEngagementService* service = SiteEngagementService::Get(&profile_);
     service->ResetScoreForURL(url, score);
   }
 
  private:
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfile profile_;
 };
 
 TEST_F(BackgroundBudgetServiceTest, GetBudgetNoBudgetOrSES) {
   const GURL origin(kTestOrigin);
 
   double budget = 0.0;
-  BackgroundBudgetService::GetBudget(profile(), origin, budget);
+  BackgroundBudgetService* service =
+      BackgroundBudgetServiceFactory::GetForProfile(profile());
+  service->GetBudget(origin, budget);
 
   EXPECT_EQ(budget, 0.0);
 }
 
 TEST_F(BackgroundBudgetServiceTest, GetBudgetNoBudgetSESExists) {
   const GURL origin(kTestOrigin);
 
   // Set a starting SES for the url but no stored budget info.
   SetSiteEngagementScore(origin, kTestSES);
 
   double budget = 0.0;
-  BackgroundBudgetService::GetBudget(profile(), origin, budget);
+  BackgroundBudgetService* service =
+      BackgroundBudgetServiceFactory::GetForProfile(profile());
+  service->GetBudget(origin, budget);
 
   EXPECT_EQ(budget, kTestSES);
 }
 
 TEST_F(BackgroundBudgetServiceTest, GetBudgetNoElapsedTime) {
   const GURL origin(kTestOrigin);
 
-  BackgroundBudgetService::StoreBudget(profile(), origin, kTestBudget);
+  BackgroundBudgetService* service =
+      BackgroundBudgetServiceFactory::GetForProfile(profile());
+  service->StoreBudget(origin, kTestBudget);
 
   double budget = 0.0;
-  BackgroundBudgetService::GetBudget(profile(), origin, budget);
+  service->GetBudget(origin, budget);
 
   EXPECT_EQ(budget, kTestBudget);
 }