Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 1889343002: Call CheckTrialGroup only under lock. (Closed)

Created:
4 years, 8 months ago by Alexei Svitkine (slow)
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Call CheckTrialGroup only under lock. Since this code can be called from multiple threads, we should hold a lock when calling CheckTrialGroup since it modifies a std::map. The other call site was already holding the lock. BUG=595264 Review URL: https://codereview.chromium.org/1810593002 Cr-Commit-Position: refs/heads/master@{#381535} (cherry picked from commit cba00314e57ab31bc5a7f766e9bb8d5760d106ac) Committed: https://chromium.googlesource.com/chromium/src/+/874f686fc9a9a937e3779757dbfeb50e69440582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M base/metrics/field_trial.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Alexei Svitkine (slow)
4 years, 8 months ago (2016-04-15 21:38:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
874f686fc9a9a937e3779757dbfeb50e69440582.

Powered by Google App Engine
This is Rietveld 408576698