Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1810593002: Call CheckTrialGroup only under lock. (Closed)

Created:
4 years, 9 months ago by Alexei Svitkine (slow)
Modified:
4 years, 9 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call CheckTrialGroup only under lock. Since this code can be called from multiple threads, we should hold a lock when calling CheckTrialGroup since it modifies a std::map. The other call site was already holding the lock. BUG=595264 Committed: https://crrev.com/cba00314e57ab31bc5a7f766e9bb8d5760d106ac Cr-Commit-Position: refs/heads/master@{#381535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M base/metrics/field_trial.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Alexei Svitkine (slow)
4 years, 9 months ago (2016-03-16 15:11:42 UTC) #2
rkaplow
lgtm
4 years, 9 months ago (2016-03-16 18:59:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810593002/1
4 years, 9 months ago (2016-03-16 19:03:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:53:09 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:56:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cba00314e57ab31bc5a7f766e9bb8d5760d106ac
Cr-Commit-Position: refs/heads/master@{#381535}

Powered by Google App Engine
This is Rietveld 408576698