Enable swarming for some test binaries on Mac GN builds.

Enable swarming for some test binaries on Mac GN builds.

R=thakis@chromium.org, rsesek@chromium.org
TBR=eroman@chromium.org
BUG=503942
Committed: https://crrev.com/de2945b8f3fdae20ed48e75644e39d83c42a2493
Cr-Commit-Position: refs/heads/master@{#387720}

[Dirk Pranke, 2016-04-15 03:01:18]

I don't actually see .dSYM files being generated by either GN or GYP builds
locally. Am I missing something?

[Dirk Pranke, 2016-04-15 04:09:54]

Well, apart from the dSYM thing, swarming appears to work fine.

I suggest we land and file a different bug to figure out what's going on w/
dSYMs, and proceed to enable more of the tests.

[Robert Sesek, 2016-04-15 15:31:36]

On 2016/04/15 03:01:18, Dirk Pranke wrote:
> I don't actually see .dSYM files being generated by either GN or GYP builds
> locally. Am I missing something?

dSYM generation is expensive so we don't generally do it. In GYP this is
controlled by a couple of variables, namely mac_strip/mac_strip_release and
mac_want_real_dsym. Generally dSYMs are only generated if we are stripping the
target too, otherwise we leave debug info in the objects/image.

[Dirk Pranke, 2016-04-15 17:03:12]

On 2016/04/15 15:31:36, Robert Sesek wrote:
> On 2016/04/15 03:01:18, Dirk Pranke wrote:
> > I don't actually see .dSYM files being generated by either GN or GYP builds
> > locally. Am I missing something?
> 
> dSYM generation is expensive so we don't generally do it. In GYP this is
> controlled by a couple of variables, namely mac_strip/mac_strip_release and
> mac_want_real_dsym. Generally dSYMs are only generated if we are stripping the
> target too, otherwise we leave debug info in the objects/image.

Ah, okay. I think we haven't implemented mac_strip_release yet, and I think I 
probably added the .dSYM/ lines at some point w/o actually checking this.

So, I guess this is good to go for now, though I'll update the comments.

Can I get a review otherwise?

[Dirk Pranke, 2016-04-15 17:03:18]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 17:03:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889033002/1

[commit-bot: I haz the power, 2016-04-15 18:02:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 18:02:27]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2016-04-15 18:06:16]

On 2016/04/15 17:03:12, Dirk Pranke wrote:
> On 2016/04/15 15:31:36, Robert Sesek wrote:
> > On 2016/04/15 03:01:18, Dirk Pranke wrote:
> > > I don't actually see .dSYM files being generated by either GN or GYP
builds
> > > locally. Am I missing something?
> > 
> > dSYM generation is expensive so we don't generally do it. In GYP this is
> > controlled by a couple of variables, namely mac_strip/mac_strip_release and
> > mac_want_real_dsym. Generally dSYMs are only generated if we are stripping
the
> > target too, otherwise we leave debug info in the objects/image.
> 
> Ah, okay. I think we haven't implemented mac_strip_release yet, and I think I 
> probably added the .dSYM/ lines at some point w/o actually checking this.
> 
> So, I guess this is good to go for now, though I'll update the comments.
> 
> Can I get a review otherwise?

Yeah this is fine for now, but the comments aren't updated.

[Nico, 2016-04-15 18:10:31]

lgtm once comment is updated

[Dirk Pranke, 2016-04-15 21:11:07]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-04-15 21:11:08]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1889033002/#ps20001
(title: "fix comments")

[commit-bot: I haz the power, 2016-04-15 21:11:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889033002/20001

[commit-bot: I haz the power, 2016-04-15 21:21:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 21:21:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dirk Pranke, 2016-04-15 21:30:13]

Description was changed from

==========
Enable swarming for some test binaries on Mac GN builds.

R=thakis@chromium.org, rsesek@chromium.org
BUG=503942
==========

to

==========
Enable swarming for some test binaries on Mac GN builds.

R=thakis@chromium.org, rsesek@chromium.org
TBR=eroman@chromium.org
BUG=503942
==========

[Dirk Pranke, 2016-04-15 21:30:13]

dpranke@chromium.org changed reviewers:
+ eroman@chromium.org

[Dirk Pranke, 2016-04-15 21:30:35]

TBR'ing eroman for the trivial build change.

[Dirk Pranke, 2016-04-15 21:30:41]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-04-15 21:31:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889033002/20001

[eroman, 2016-04-15 22:09:08]

lgtm

[commit-bot: I haz the power, 2016-04-15 22:14:21]

Description was changed from

==========
Enable swarming for some test binaries on Mac GN builds.

R=thakis@chromium.org, rsesek@chromium.org
TBR=eroman@chromium.org
BUG=503942
==========

to

==========
Enable swarming for some test binaries on Mac GN builds.

R=thakis@chromium.org, rsesek@chromium.org
TBR=eroman@chromium.org
BUG=503942
==========

[commit-bot: I haz the power, 2016-04-15 22:14:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-15 22:16:38]

Description was changed from

==========
Enable swarming for some test binaries on Mac GN builds.

R=thakis@chromium.org, rsesek@chromium.org
TBR=eroman@chromium.org
BUG=503942
==========

to

==========
Enable swarming for some test binaries on Mac GN builds.

R=thakis@chromium.org, rsesek@chromium.org
TBR=eroman@chromium.org
BUG=503942

Committed: https://crrev.com/de2945b8f3fdae20ed48e75644e39d83c42a2493
Cr-Commit-Position: refs/heads/master@{#387720}
==========

[commit-bot: I haz the power, 2016-04-15 22:16:39]

Patchset 2 (id:??) landed as
https://crrev.com/de2945b8f3fdae20ed48e75644e39d83c42a2493
Cr-Commit-Position: refs/heads/master@{#387720}