Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: ui/base/BUILD.gn

Issue 1889033002: Enable swarming for some test binaries on Mac GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/buildbot/chromium.mac.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index fa9817394bcf29ec67cd7517d4703af78ddff285..d229003c647d721a541707f03efbdc6c0878237c 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -945,7 +945,8 @@ test("ui_base_unittests") {
data += [ "$root_out_dir/ui_unittests Framework.framework/" ]
if (is_asan && symbol_level == 0) {
- data += [ "$root_out_dir/ui_base_unittests.dSYM/" ]
+ # TODO(crbug.com/330301): make this conditional on mac_strip_release.
+ # data += [ "$root_out_dir/ui_base_unittests.dSYM/" ]
}
}
}
« no previous file with comments | « testing/buildbot/chromium.mac.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698