Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188903003: Revert "Drive SVG Animations via requestAnimationFrame" (Closed)

Created:
6 years, 9 months ago by cbiesinger
Modified:
6 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Revert "Drive SVG Animations via requestAnimationFrame" This reverts commit 428bb7c6dc0c0cba317738e0a9bdaeb4bdb4bce6. Suspected of causing various layout tests to fail, e.g.: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/12115 TBR=fs@opera.com BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -136 lines) Patch
M Source/core/animation/AnimationClock.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/DocumentTimeline.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/PageAnimator.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.h View 4 chunks +2 lines, -12 lines 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 12 chunks +18 lines, -68 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 4 chunks +5 lines, -19 lines 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.cpp View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
cbiesinger
Committed patchset #1 manually as r168674 (presubmit successful).
6 years, 9 months ago (2014-03-06 20:38:49 UTC) #1
cbiesinger
On 2014/03/06 20:38:49, cbiesinger wrote: > Committed patchset #1 manually as r168674 (presubmit successful). Oh, ...
6 years, 9 months ago (2014-03-06 20:39:34 UTC) #2
pdr.
6 years, 9 months ago (2014-03-06 20:40:05 UTC) #3
Message was sent while issue was closed. 
On 2014/03/06 20:38:49, cbiesinger wrote:
> Committed patchset #1 manually as r168674 (presubmit successful).

Yeah, I think this did regress :(

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

Powered by Google App Engine
This is Rietveld 408576698