Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: net/url_request/url_request_test_util.h

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme
Patch Set: more addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_test_util.h
diff --git a/net/url_request/url_request_test_util.h b/net/url_request/url_request_test_util.h
index a18ef8ce1303a8bfc11779a9e95f59f0139cad2e..d5d7dd3d203df78b7b45dc0abfd4ed7ee700a175 100644
--- a/net/url_request/url_request_test_util.h
+++ b/net/url_request/url_request_test_util.h
@@ -38,10 +38,12 @@
#include "net/http/http_request_headers.h"
#include "net/proxy/proxy_service.h"
#include "net/ssl/ssl_config_service_defaults.h"
+#include "net/url_request/http_protocol_handler.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_getter.h"
#include "net/url_request/url_request_context_storage.h"
+#include "net/url_request/url_request_interceptor.h"
#include "net/url_request/url_request_job_factory.h"
#include "url/url_util.h"
@@ -409,13 +411,21 @@ class TestNetworkDelegate : public NetworkDelegateImpl {
//-----------------------------------------------------------------------------
-// A simple ProtocolHandler that returns a pre-built URLRequestJob only once.
-class TestJobInterceptor : public URLRequestJobFactory::ProtocolHandler {
+// A simple ProtocolHandler that returns a pre-built URLRequestJob only once,
+// and falls back to a normal HttpProtocolHandler implementation if no pre-built
+// URLRequestJob is present.
+class TestJobInterceptor : public URLRequestInterceptor {
public:
TestJobInterceptor();
~TestJobInterceptor() override;
- URLRequestJob* MaybeCreateJob(
+ URLRequestJob* MaybeInterceptRequest(
+ URLRequest* request,
+ NetworkDelegate* network_delegate) const override;
+ URLRequestJob* MaybeInterceptRedirect(URLRequest* request,
+ NetworkDelegate* network_delegate,
+ const GURL& location) const override;
+ URLRequestJob* MaybeInterceptResponse(
URLRequest* request,
NetworkDelegate* network_delegate) const override;
void set_main_intercept_job(std::unique_ptr<URLRequestJob> job);

Powered by Google App Engine
This is Rietveld 408576698