Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: net/url_request/http_protocol_handler.cc

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme
Patch Set: more addressing comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/http_protocol_handler.cc
diff --git a/net/url_request/http_protocol_handler.cc b/net/url_request/http_protocol_handler.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bf8e74b4454bba8380a6e3e588dd6d50a304e0df
--- /dev/null
+++ b/net/url_request/http_protocol_handler.cc
@@ -0,0 +1,41 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/url_request/http_protocol_handler.h"
+#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_context.h"
+#include "net/url_request/url_request_error_job.h"
+#include "net/url_request/url_request_http_job.h"
+#include "net/url_request/url_request_redirect_job.h"
+#include "url/gurl.h"
+
+namespace net {
+
+HttpProtocolHandler::HttpProtocolHandler() {}
+
+URLRequestJob* HttpProtocolHandler::MaybeCreateJob(
+ URLRequest* request,
+ NetworkDelegate* network_delegate) const {
+ DCHECK(request->url().scheme() == "http" ||
+ request->url().scheme() == "https" ||
+ request->url().scheme() == "ws" || request->url().scheme() == "wss");
mmenke 2016/04/28 16:52:41 nit: While you're here, mind switching these to t
mgersh 2016/04/28 20:36:30 Done.
+
+ if (!request->context()->http_transaction_factory()) {
+ NOTREACHED() << "requires a valid context";
mmenke 2016/04/28 16:52:41 nit: include base/logging for NOTREACHED
mgersh 2016/04/28 20:36:30 Done.
+ return new URLRequestErrorJob(request, network_delegate,
+ ERR_INVALID_ARGUMENT);
mmenke 2016/04/28 16:52:41 nit: Include net/base/net_error.h
mgersh 2016/04/28 20:36:30 Done.
+ }
+
+ GURL redirect_url;
+ if (request->GetHSTSRedirect(&redirect_url)) {
+ return new URLRequestRedirectJob(
+ request, network_delegate, redirect_url,
+ // Use status code 307 to preserve the method, so POST requests work.
+ URLRequestRedirectJob::REDIRECT_307_TEMPORARY_REDIRECT, "HSTS");
+ }
+ return new URLRequestHttpJob(request, network_delegate,
+ request->context()->http_user_agent_settings());
+}
+
+} // namespace net

Powered by Google App Engine
This is Rietveld 408576698