components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc - Issue 1888963004: Add HttpProtocolHandler and convert everything to use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme

Patch Set: even more rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/ios/cronet_environment.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc ('k') | content/browser/loader/resource_loader_unittest.cc » ('j') | content/browser/loader/resource_loader_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

index 8b6f768042fc3bf244ce29d6c055462228e1df03..17d0fe6340483aac663704a9f6857a7e9c02b823 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

@@ -601,11 +601,12 @@ void DataReductionProxyTestContext::AttachToURLRequestContext(

io_data()->CreateNetworkDelegate(

base::WrapUnique(new net::TestNetworkDelegate()), true));

+ std::unique_ptr<net::URLRequestJobFactory> job_factory_impl =

+ net::URLRequestJobFactoryImpl::CreateWithDefaultProtocolHandlers();

request_context_storage->set_job_factory(

base::WrapUnique(new net::URLRequestInterceptingJobFactory(

- std::unique_ptr<net::URLRequestJobFactory>(

- new net::URLRequestJobFactoryImpl()),

- io_data()->CreateInterceptor())));

+ std::move(job_factory_impl), io_data()->CreateInterceptor())));

}

void DataReductionProxyTestContext::