components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc - Issue 1888963004: Add HttpProtocolHandler and convert everything to use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme

Patch Set: even more rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/ios/cronet_environment.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc » ('j') | content/browser/loader/resource_loader_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

index 95b485c32afd99cc0306ad496a19b17b5330ee59..5b5909353d5238e9d5253e60941ae69a249d4054 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc

@@ -147,8 +147,8 @@ class DataReductionProxyInterceptorTest : public testing::Test {

#endif

TEST_F(DataReductionProxyInterceptorTest, MAYBE_TestJobFactoryChaining) {

// Verifies that job factories can be chained.

- std::unique_ptr<net::URLRequestJobFactory> impl(

- new net::URLRequestJobFactoryImpl());

+ std::unique_ptr<net::URLRequestJobFactory> impl =

+ net::URLRequestJobFactoryImpl::CreateWithDefaultProtocolHandlers();

CountingURLRequestInterceptor* interceptor2 =

new CountingURLRequestInterceptor();

@@ -222,8 +222,8 @@ class DataReductionProxyInterceptorWithServerTest : public testing::Test {

context_.set_proxy_service(proxy_service_.get());

- std::unique_ptr<net::URLRequestJobFactoryImpl> job_factory_impl(

- new net::URLRequestJobFactoryImpl());

+ std::unique_ptr<net::URLRequestJobFactoryImpl> job_factory_impl =

+ net::URLRequestJobFactoryImpl::CreateWithDefaultProtocolHandlers();

job_factory_.reset(new net::URLRequestInterceptingJobFactory(

std::move(job_factory_impl),

test_context_->io_data()->CreateInterceptor()));