Add HttpProtocolHandler and convert everything to use it

android_webview/browser/net/aw_url_request_job_factory.cc

Index: android_webview/browser/net/aw_url_request_job_factory.cc
diff --git a/android_webview/browser/net/aw_url_request_job_factory.cc b/android_webview/browser/net/aw_url_request_job_factory.cc
index 0d8ddecff1c11e981f5752df85d339c92007f3db..ccadf5ff45491c25a9568b8e3619b9aa709574e1 100644
--- a/android_webview/browser/net/aw_url_request_job_factory.cc
+++ b/android_webview/browser/net/aw_url_request_job_factory.cc
@@ -26,12 +26,6 @@ AwURLRequestJobFactory::~AwURLRequestJobFactory() {
 
 bool AwURLRequestJobFactory::IsHandledProtocol(
     const std::string& scheme) const {
-  // This introduces a dependency on the URLRequestJobManager
-  // implementation. The assumption is that if true is returned from this
-  // method it is still valid to return NULL from the
-  // MaybeCreateJobWithProtocolHandler method and in that case the
-  // URLRequestJobManager will try and create the URLRequestJob by using the
-  // set of built in handlers.
   return true;
 }
 
@@ -49,15 +43,6 @@ URLRequestJob* AwURLRequestJobFactory::MaybeCreateJobWithProtocolHandler(
   if (job)
     return job;

[mmenke, 2016/04/22 18:37:52]

This will switch some failures from ERR_FAILED to ERR_UNKNOWN_URL_SCHEME, at
least until you move all creation down into URLRequestFactoryImpl.  I don't
think we really care, though.

 
-  // If a URLRequestJobManager built-in factory supports the scheme, NULL should
-  // be returned from this method.
-  // In that case the built in handlers will then be used to create the job.
-  // TODO(mgersh): remove this check once HttpProtocolHandler exists and is
-  // added to the relevant URLRequestJobFactory.
-  // NOTE(joth): See the assumption in IsHandledProtocol above.
-  if (next_factory_->IsHandledProtocol(scheme))
-    return NULL;
-
   return new net::URLRequestErrorJob(
       request, network_delegate, net::ERR_UNKNOWN_URL_SCHEME);
 }