Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: android_webview/browser/net/aw_url_request_context_getter.cc

Issue 1888963004: Add HttpProtocolHandler and convert everything to use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-supports-scheme
Patch Set: even more rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/net/aw_url_request_context_getter.cc
diff --git a/android_webview/browser/net/aw_url_request_context_getter.cc b/android_webview/browser/net/aw_url_request_context_getter.cc
index 4b959ae54cacc5f52f83007e340893cbdafdba98..10918c791150b7bf18c659c16955d6f1ac93ed70 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.cc
+++ b/android_webview/browser/net/aw_url_request_context_getter.cc
@@ -49,6 +49,7 @@
#include "net/ssl/channel_id_service.h"
#include "net/url_request/data_protocol_handler.h"
#include "net/url_request/file_protocol_handler.h"
+#include "net/url_request/http_protocol_handler.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_builder.h"
#include "net/url_request/url_request_intercepting_job_factory.h"
@@ -104,6 +105,18 @@ std::unique_ptr<net::URLRequestJobFactory> CreateJobFactory(
// Note that the registered schemes must also be specified in
// AwContentBrowserClient::IsHandledURL.
bool set_protocol = aw_job_factory->SetProtocolHandler(
+ url::kHttpScheme, base::WrapUnique(new net::HttpProtocolHandler));
+ DCHECK(set_protocol);
+ set_protocol = aw_job_factory->SetProtocolHandler(
+ url::kHttpsScheme, base::WrapUnique(new net::HttpProtocolHandler));
+ DCHECK(set_protocol);
+ set_protocol = aw_job_factory->SetProtocolHandler(
+ url::kWsScheme, base::WrapUnique(new net::HttpProtocolHandler));
+ DCHECK(set_protocol);
+ set_protocol = aw_job_factory->SetProtocolHandler(
+ url::kWssScheme, base::WrapUnique(new net::HttpProtocolHandler));
+ DCHECK(set_protocol);
mmenke 2016/04/22 18:37:52 Maybe make AwURLRequestJobFactory::AwURLRequestJob
mgersh 2016/04/22 20:27:15 Done.
+ set_protocol = aw_job_factory->SetProtocolHandler(
url::kFileScheme,
base::WrapUnique(new net::FileProtocolHandler(
content::BrowserThread::GetBlockingPool()

Powered by Google App Engine
This is Rietveld 408576698