Make NeedsRebaseline illegal in layout_test TestExpectations for now.

Make NeedsRebaseline illegal in layout_test TestExpectations for now.

In order to keep too many NeedsRebaseline lines from piling up
in the TestExpectations while the auto-rebaseline-bot is down
(and causing us to potentially miss breakages as a result), this
change makes checking in NeedsRebaseline illegal (like Rebaseline currently
is).

Users can still manually rebaseline things if need be.

We should revert this change once the auto-rebaseline-bot is back up.

R=esprehn@chromium.org, ojan@chromium.org, wkorman@chromium.org
BUG=603753
Committed: https://crrev.com/5f6db60551a6cd52e4c0638a1ed669eecf25af3b
Cr-Commit-Position: refs/heads/master@{#387539}

[esprehn, 2016-04-15 01:59:44]

lgtm, I wish we could make the presubmit actually check to see if the bot was
running too.

[Dirk Pranke, 2016-04-15 02:06:31]

On 2016/04/15 01:59:44, esprehn wrote:
> lgtm, I wish we could make the presubmit actually check to see if the bot was
> running too.

Yeah, unfortunately, I think asking the presubmit bot to talk to the network
might actually be  a cure worse than the disease.

[Dirk Pranke, 2016-04-15 02:06:36]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-04-15 02:06:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888963003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888963003/1

[commit-bot: I haz the power, 2016-04-15 02:08:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 02:08:46]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[esprehn, 2016-04-15 02:11:28]

On 2016/04/15 at 02:06:31, dpranke wrote:
> On 2016/04/15 01:59:44, esprehn wrote:
> > lgtm, I wish we could make the presubmit actually check to see if the bot
was
> > running too.
> 
> Yeah, unfortunately, I think asking the presubmit bot to talk to the network
might actually be  a cure worse than the disease.

Doesn't it already do that to check if the tree is open?

[Dirk Pranke, 2016-04-15 02:14:55]

On 2016/04/15 02:11:28, esprehn wrote:
> On 2016/04/15 at 02:06:31, dpranke wrote:
> > On 2016/04/15 01:59:44, esprehn wrote:
> > > lgtm, I wish we could make the presubmit actually check to see if the bot
> was
> > > running too.
> > 
> > Yeah, unfortunately, I think asking the presubmit bot to talk to the network
> might actually be  a cure worse than the disease.
> 
> Doesn't it already do that to check if the tree is open?

Good question. I think that check is skipped when the chromium_presubmit
bots, to avoid this problem, and the CQ itself is the thing that enforces the
tree being open.

https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presu...

[Dirk Pranke, 2016-04-15 02:15:00]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-04-15 02:15:00]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1888963003/#ps20001
(title: "merge TestExpectations")

[commit-bot: I haz the power, 2016-04-15 02:15:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888963003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888963003/20001

[commit-bot: I haz the power, 2016-04-15 03:18:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 03:18:39]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2016-04-15 04:16:12]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-04-15 04:16:12]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1888963003/#ps40001
(title: "disable broken webkitpy tests")

[commit-bot: I haz the power, 2016-04-15 04:16:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1888963003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1888963003/40001

[commit-bot: I haz the power, 2016-04-15 05:24:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-15 05:26:04]

Description was changed from

==========
Make NeedsRebaseline illegal in layout_test TestExpectations for now.

In order to keep too many NeedsRebaseline lines from piling up
in the TestExpectations while the auto-rebaseline-bot is down
(and causing us to potentially miss breakages as a result), this
change makes checking in NeedsRebaseline illegal (like Rebaseline currently
is).

Users can still manually rebaseline things if need be.

We should revert this change once the auto-rebaseline-bot is back up.

R=esprehn@chromium.org, ojan@chromium.org, wkorman@chromium.org
BUG=603753
==========

to

==========
Make NeedsRebaseline illegal in layout_test TestExpectations for now.

In order to keep too many NeedsRebaseline lines from piling up
in the TestExpectations while the auto-rebaseline-bot is down
(and causing us to potentially miss breakages as a result), this
change makes checking in NeedsRebaseline illegal (like Rebaseline currently
is).

Users can still manually rebaseline things if need be.

We should revert this change once the auto-rebaseline-bot is back up.

R=esprehn@chromium.org, ojan@chromium.org, wkorman@chromium.org
BUG=603753

Committed: https://crrev.com/5f6db60551a6cd52e4c0638a1ed669eecf25af3b
Cr-Commit-Position: refs/heads/master@{#387539}
==========

[commit-bot: I haz the power, 2016-04-15 05:26:05]

Patchset 3 (id:??) landed as
https://crrev.com/5f6db60551a6cd52e4c0638a1ed669eecf25af3b
Cr-Commit-Position: refs/heads/master@{#387539}